netdev - Re: [PATCH net] net: do not consume a cacheline for system_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34e94b33-94cb-42ae-bc58-8ab4f7b44801@kernel.org>
Date: Thu, 28 Mar 2024 21:35:52 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Lorenzo Bianconi <lorenzo@...nel.org>,
 Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH net] net: do not consume a cacheline for system_page_pool

On 28/03/2024 18.34, Eric Dumazet wrote:
> There is no reason to consume a full cacheline to store system_page_pool.
> 
> We can eventually move it to softnet_data later for full locality control.
> 
> Fixes: 2b0cfa6e4956 ("net: add generic percpu page_pool allocator")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Lorenzo Bianconi <lorenzo@...nel.org>
> Cc: Jesper Dangaard Brouer <hawk@...nel.org>
> Cc: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
>   net/core/dev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 9a67003e49db87f3f92b6c6296b3e7a5ca9d9171..984ff8b9d0e1aa5646a7237a8cf0b0a21c2aa559 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -429,7 +429,7 @@ EXPORT_PER_CPU_SYMBOL(softnet_data);
>    * PP consumers must pay attention to run APIs in the appropriate context
>    * (e.g. NAPI context).
>    */
> -static DEFINE_PER_CPU_ALIGNED(struct page_pool *, system_page_pool);
> +static DEFINE_PER_CPU(struct page_pool *, system_page_pool);
>   
>   #ifdef CONFIG_LOCKDEP
>   /*