netdev - Re: [PATCH] wifi: mac80222: Fix ieee80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86de9e81-7ac4-4609-bd18-d92e7244e2a5@quicinc.com>
Date: Thu, 28 Mar 2024 16:07:39 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Randy Dunlap <rdunlap@...radead.org>,
        Johannes Berg
	<johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>
CC: <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: mac80222: Fix ieee80211_i.h kernel-doc issues

On 3/28/2024 3:16 PM, Randy Dunlap wrote:
> Hi,
> 
> On 3/28/24 14:08, Jeff Johnson wrote:
>> kernel-doc flagged the following issues:
>>
>> net/mac80211/ieee80211_i.h:146: warning: expecting prototype for enum ieee80211_corrupt_data_flags. Prototype was for enum ieee80211_bss_corrupt_data_flags instead
>> net/mac80211/ieee80211_i.h:163: warning: expecting prototype for enum ieee80211_valid_data_flags. Prototype was for enum ieee80211_bss_valid_data_flags instead
>>
>> Correct the documentation to match the code.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> 
> These seem to be corrected in linux-next already.

Looks like I fixed these two earlier -- not sure why they haven't reached
wireless-next yet which was the code I was looking at today.

I've flagged as N/A in patchwork

> However, I do still see this one:
> 
> ieee80211_i.h:689: warning: missing initial short description on line:
>  * struct mesh_table

Ah, I haven't been adding [-Wshort-desc[ription]]  (or some of the other -W
switches)

Yay, I can find even more issues.

I'll fix this one