netdev - Re: [PATCH v2 6.1.y] net: tls: handle backlogging of crypto requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 12:49:59 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Srish Srinivasan <srish.srinivasan@...adcom.com>
Cc: ajay.kaher@...adcom.com, alexey.makhalov@...adcom.com,
	borisp@...dia.com, davejwatson@...com, davem@...emloft.net,
	edumazet@...gle.com, horms@...nel.org, john.fastabend@...il.com,
	kuba@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com,
	sashal@...nel.org, sd@...asysnail.net, stable@...r.kernel.org,
	vakul.garg@....com, vasavi.sirnapalli@...adcom.com
Subject: Re: [PATCH v2 6.1.y] net: tls: handle backlogging of crypto requests

On Fri, Mar 29, 2024 at 03:55:40PM +0530, Srish Srinivasan wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> 
> commit 8590541473188741055d27b955db0777569438e3 upstream
> 
> Since we're setting the CRYPTO_TFM_REQ_MAY_BACKLOG flag on our
> requests to the crypto API, crypto_aead_{encrypt,decrypt} can return
>  -EBUSY instead of -EINPROGRESS in valid situations. For example, when
> the cryptd queue for AESNI is full (easy to trigger with an
> artificially low cryptd.cryptd_max_cpu_qlen), requests will be enqueued
> to the backlog but still processed. In that case, the async callback
> will also be called twice: first with err == -EINPROGRESS, which it
> seems we can just ignore, then with err == 0.
> 
> Compared to Sabrina's original patch this version uses the new
> tls_*crypt_async_wait() helpers and converts the EBUSY to
> EINPROGRESS to avoid having to modify all the error handling
> paths. The handling is identical.
> 
> Fixes: a54667f6728c ("tls: Add support for encryption using async offload accelerator")
> Fixes: 94524d8fc965 ("net/tls: Add support for async decryption of tls records")
> Co-developed-by: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> Link: https://lore.kernel.org/netdev/9681d1febfec295449a62300938ed2ae66983f28.1694018970.git.sd@queasysnail.net/
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> [Srish: v2: fixed hunk failures
>         fixed merge-conflict in stable branch linux-6.1.y,
>         needs to go on top of https://lore.kernel.org/stable/20240307155930.913525-1-lee@kernel.org/]

Identical do what I queued up for v1, but oh well :)

thanks,

greg k-h