netdev - Re: [PATCH net-next v2] devlink: use kvzalloc() to allocate devlink instance resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240328184958.3638e5a0@kernel.org>
Date: Thu, 28 Mar 2024 18:49:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Jian Wen <wenjianhn@...il.com>, <jiri@...lanox.com>,
 <edumazet@...gle.com>, <davem@...emloft.net>, "Jian Wen"
 <wenjian1@...omi.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] devlink: use kvzalloc() to allocate devlink
 instance resources

On Wed, 27 Mar 2024 11:15:08 +0100 Alexander Lobakin wrote:
> > Changes since v1:
> > - Use struct_size(devlink, priv, priv_size) as suggested by Alexander Lobakin

The change log should go under ---
and would be great to include a link to the previous version (from lore)

> > Signed-off-by: Jian Wen <wenjian1@...omi.com>  
> 
> Since it actually fixes a bug splat, you may want to send it with prefix
> "net" instead of "net-next" and add a "Fixes:" tag here blaming the
> first commit which added Devlink instance allocation. Let's see what
> others think.

That's my initial reaction as well. We often treat memory
pressure improvements as fixes. But thinking more we would
need to check if any of the drivers puts a DMA buffer in its priv.
Some FW mailbox, maybe? It's possible.