netdev - Re: [PATCH net-next] tcp/dccp: bypass empty buckets in inet_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJQ2HGbeufp=Kx3BketFt_D4u6sRo+qJae2syyzUricdA@mail.gmail.com>
Date: Fri, 29 Mar 2024 16:24:16 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, davem@...emloft.net, eric.dumazet@...il.com, 
	netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] tcp/dccp: bypass empty buckets in inet_twsk_purge()

On Fri, Mar 29, 2024 at 4:06 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 27 Mar 2024 12:29:34 -0700 Kuniyuki Iwashima wrote:
> > > -   for (slot = 0; slot <= hashinfo->ehash_mask; slot++) {
> > > -           struct inet_ehash_bucket *head = &hashinfo->ehash[slot];
> > > +   for (slot = 0; slot <= ehash_mask; slot++, head++) {
> > > +
> >
> > unnecessary blank link here.
>
> I've seen some other core kernel contributors add empty lines after
> for or if statements, so I think this is intentional. Not sure why
> the empty line helps, either, TBH, but we have been letting it slide
> so far.

I will delete this extra line in the following patch, thanks !