netdev - Re: [PATCH net] selftests: reuseaddr_conflict: add missing new line at the end of the output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <489b5f4c-a7a0-4c8a-888f-ccf09d4bd81f@collabora.com>
Date: Sat, 30 Mar 2024 00:35:51 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, netdev@...r.kernel.org,
 edumazet@...gle.com, pabeni@...hat.com, shuah@...nel.org, jbacik@...com,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: reuseaddr_conflict: add missing new line
 at the end of the output

On 3/29/24 9:05 PM, Jakub Kicinski wrote:
> The netdev CI runs in a VM and captures serial, so stdout and
> stderr get combined. Because there's a missing new line in
> stderr the test ends up corrupting KTAP:
> 
>   # Successok 1 selftests: net: reuseaddr_conflict
> 
> which should have been:
> 
>   # Success
>   ok 1 selftests: net: reuseaddr_conflict
> 
> Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
> Low risk and seems worth backporting to stable, hence the fixes tag.
Agreed to back port it as ok or not ok must appear at the start of the line
to indicate the status of the test.

> 
> CC: shuah@...nel.org
> CC: jbacik@...com
> CC: linux-kselftest@...r.kernel.org
> ---
>  tools/testing/selftests/net/reuseaddr_conflict.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/reuseaddr_conflict.c b/tools/testing/selftests/net/reuseaddr_conflict.c
> index 7c5b12664b03..bfb07dc49518 100644
> --- a/tools/testing/selftests/net/reuseaddr_conflict.c
> +++ b/tools/testing/selftests/net/reuseaddr_conflict.c
> @@ -109,6 +109,6 @@ int main(void)
>  	fd1 = open_port(0, 1);
>  	if (fd1 >= 0)
>  		error(1, 0, "Was allowed to create an ipv4 reuseport on an already bound non-reuseport socket with no ipv6");
> -	fprintf(stderr, "Success");
> +	fprintf(stderr, "Success\n");
>  	return 0;
>  }

-- 
BR,
Muhammad Usama Anjum