netdev - Re: [PATCH net-next v1 5/9] net: dsa: microchip: add support for different DCB app configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403291727.iblGz7u1-lkp@intel.com>
Date: Fri, 29 Mar 2024 17:33:58 +0800
From: kernel test robot <lkp@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>, Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Arun Ramadoss <arun.ramadoss@...rochip.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	Oleksij Rempel <o.rempel@...gutronix.de>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com,
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>,
	Willem de Bruijn <willemb@...gle.com>,
	Søren Andersen <san@...v.dk>
Subject: Re: [PATCH net-next v1 5/9] net: dsa: microchip: add support for
 different DCB app configurations

Hi Oleksij,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/net-dsa-add-support-for-DCB-get-set-apptrust-configuration/20240329-000847
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240328160518.2396238-6-o.rempel%40pengutronix.de
patch subject: [PATCH net-next v1 5/9] net: dsa: microchip: add support for different DCB app configurations
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240329/202403291727.iblGz7u1-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240329/202403291727.iblGz7u1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403291727.iblGz7u1-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/microchip/ksz_dcb.c:81: warning: cannot understand function prototype: 'const u8 ksz_supported_apptrust[] = '


vim +81 drivers/net/dsa/microchip/ksz_dcb.c

    53	
    54	/**
    55	 * ksz_supported_apptrust[] - Supported apptrust selectors and Priority Order
    56	 *			      of Internal Priority Value (IPV) sources.
    57	 *
    58	 * This array defines the apptrust selectors supported by the hardware, where
    59	 * the index within the array indicates the priority of the selector - lower
    60	 * indices correspond to higher priority. This fixed priority scheme is due to
    61	 * the hardware's design, which does not support configurable priority among
    62	 * different priority sources.
    63	 *
    64	 * The priority sources, including Tail Tag, ACL, VLAN PCP and DSCP are ordered
    65	 * by the hardware's fixed logic, as detailed below. The order reflects a
    66	 * non-configurable precedence where certain types of priority information
    67	 * override others:
    68	 *
    69	 * 1. Tail Tag - Highest priority, overrides ACL, VLAN PCP, and DSCP priorities.
    70	 * 2. ACL - Overrides VLAN PCP and DSCP priorities.
    71	 * 3. VLAN PCP - Overrides DSCP priority.
    72	 * 4. DSCP - Lowest priority, does not override any other priority source.
    73	 *
    74	 * In this context, the array's lower index (higher priority) for
    75	 * 'DCB_APP_SEL_PCP' suggests its relative priority over
    76	 * 'IEEE_8021QAZ_APP_SEL_DSCP' within the system's fixed priority scheme.
    77	 *
    78	 * DCB_APP_SEL_PCP - Priority Code Point selector
    79	 * IEEE_8021QAZ_APP_SEL_DSCP - Differentiated Services Code Point selector
    80	 */
  > 81	static const u8 ksz_supported_apptrust[] = {
    82		DCB_APP_SEL_PCP,
    83		IEEE_8021QAZ_APP_SEL_DSCP,
    84	};
    85	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki