[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALUcmU=xOR1j9Asdv0Ny7x=o4Ckz80mDjbuEnJC0Z_Aepu0Zzw@mail.gmail.com>
Date: Fri, 29 Mar 2024 10:47:39 +0100
From: Arthur Borsboom <arthurborsboom@...il.com>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: netdev@...r.kernel.org, Ilias Apalodimas <ilias.apalodimas@...aro.org>, wei.liu@...nel.org,
paul@....org, Jakub Kicinski <kuba@...nel.org>, kirjanov@...il.com, dkirjanov@...e.de,
kernel-team@...udflare.com, security@...project.org,
andrew.cooper3@...rix.com, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH net] xen-netfront: Add missing skb_mark_for_recycle
On Wed, 27 Mar 2024 at 13:15, Jesper Dangaard Brouer <hawk@...nel.org> wrote:
>
> Notice that skb_mark_for_recycle() is introduced later than fixes tag in
> 6a5bcd84e886 ("page_pool: Allow drivers to hint on SKB recycling").
>
> It is believed that fixes tag were missing a call to page_pool_release_page()
> between v5.9 to v5.14, after which is should have used skb_mark_for_recycle().
> Since v6.6 the call page_pool_release_page() were removed (in 535b9c61bdef
> ("net: page_pool: hide page_pool_release_page()") and remaining callers
> converted (in commit 6bfef2ec0172 ("Merge branch
> 'net-page_pool-remove-page_pool_release_page'")).
>
> This leak became visible in v6.8 via commit dba1b8a7ab68 ("mm/page_pool: catch
> page_pool memory leaks").
>
> Fixes: 6c5aa6fc4def ("xen networking: add basic XDP support for xen-netfront")
> Reported-by: Arthur Borsboom <arthurborsboom@...il.com>
> Signed-off-by: Jesper Dangaard Brouer <hawk@...nel.org>
> ---
> Compile tested only, can someone please test this
I have tested this patch on Xen 4.18.1 with VM (Arch Linux) kernel 6.9.0-rc1.
Without the patch there are many trace traces and cloning the Linux
mainline git repository resulted in failures (same with kernel 6.8.1).
The patched kernel 6.9.0-rc1 performs as expected; cloning the git
repository was successful and no kernel traces observed.
Hereby my tested by:
Tested-by: Arthur Borsboom <arthurborsboom@...il.com>
> drivers/net/xen-netfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index ad29f370034e..8d2aee88526c 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -285,6 +285,7 @@ static struct sk_buff *xennet_alloc_one_rx_buffer(struct netfront_queue *queue)
> return NULL;
> }
> skb_add_rx_frag(skb, 0, page, 0, 0, PAGE_SIZE);
> + skb_mark_for_recycle(skb);
>
> /* Align ip header to a 16 bytes boundary */
> skb_reserve(skb, NET_IP_ALIGN);
>
>
Powered by blists - more mailing lists