netdev - Re: [PATCH net-next v2 7/7] arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01b0a1bc-861a-43bc-85cd-dd4f23b302d8@gmail.com>
Date: Sun, 31 Mar 2024 09:35:39 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>,
 Gregory Clement <gregory.clement@...tlin.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 7/7] arm: boot: dts: mvebu: linksys-mamba: Add
 Ethernet LEDs

On 3/30/2024 11:32 AM, Andrew Lunn wrote:
> List the front panel Ethernet LEDs in the switch section of the
> device tree. They can then be controlled via /sys/class/led/
> 
> The node contains a label property to influence the name of the LED.
> Without it, all the LEDs get the name lan:white, which classes, and so
> some get a number appended. lan:white_1, lan:white_2, etc. Using the
> label the LEDs are named lan1:front, lan2:front, lan3:front, where
> lanX indicates the interface name, and front indicates they are on the
> front of the box.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
[snip]
>   			ethernet-port@4 {
>   				reg = <4>;
>   				label = "internet";
> +
> +				leds {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +
> +					led@0 {
> +						reg = <0>;
> +						color = <LED_COLOR_ID_WHITE>;
> +						function = LED_FUNCTION_LAN;

Should this be LED_FUNCTION_WAN since this is the "internet" label?
-- 
Florian