netdev - Re: [PATCH net-next v2 1/2] net/iucv: Avoid explicit cpumask var allocation on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4110b0fb-0005-45b6-9996-978b9bab8beb@linux.ibm.com>
Date: Tue, 2 Apr 2024 14:41:24 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Dawei Li <dawei.li@...ngroup.cn>, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, ioana.ciornei@....com,
        twinkler@...ux.ibm.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net/iucv: Avoid explicit cpumask var
 allocation on stack



On 31.03.24 07:34, Dawei Li wrote:
> For CONFIG_CPUMASK_OFFSTACK=y kernel, explicit allocation of cpumask
> variable on stack is not recommended since it can cause potential stack
> overflow.
> 
> Instead, kernel code should always use *cpumask_var API(s) to allocate
> cpumask var in config-neutral way, leaving allocation strategy to
> CONFIG_CPUMASK_OFFSTACK.
> 
> Use *cpumask_var API(s) to address it.
> 
> Signed-off-by: Dawei Li <dawei.li@...ngroup.cn>
> ---

LGTM; 
Thank you Eric for the comment and solution with the 'static' keyword.
Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>