netdev - Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea4ac7a3-13ae-4d22-a3d9-fcb7d9e8d751@linux.ibm.com>
Date: Tue, 2 Apr 2024 14:48:14 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Allen Pais <apais@...ux.microsoft.com>, linux-kernel@...r.kernel.org
Cc: tj@...nel.org, keescook@...omium.org, vkoul@...nel.org, marcan@...can.st,
        sven@...npeter.dev, florian.fainelli@...adcom.com, rjui@...adcom.com,
        sbranden@...adcom.com, paul@...pouillou.net,
        Eugeniy.Paltsev@...opsys.com, manivannan.sadhasivam@...aro.org,
        vireshk@...nel.org, Frank.Li@....com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, haijie1@...wei.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        afaerber@...e.de, logang@...tatee.com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr, andersson@...nel.org,
        konrad.dybcio@...aro.org, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org, wens@...e.org,
        jernej.skrabec@...il.com, peter.ujfalusi@...il.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        jassisinghbrar@...il.com, mchehab@...nel.org,
        maintainers@...echerrydvr.com, aubin.constans@...rochip.com,
        ulf.hansson@...aro.org, manuel.lauss@...il.com,
        mirq-linux@...e.qmqm.pl, jh80.chung@...sung.com, oakad@...oo.com,
        hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
        brucechang@....com.tw, HaraldWelte@...tech.com, pierre@...man.eu,
        duncan.sands@...e.fr, stern@...land.harvard.edu, oneukum@...e.com,
        openipmi-developer@...ts.sourceforge.net, dmaengine@...r.kernel.org,
        asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        imx@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
        linux-mediatek@...ts.infradead.org, linux-actions@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue



On 27.03.24 17:03, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/infiniband/* from tasklet to BH workqueue.
> 
> Based on the work done by Tejun Heo <tj@...nel.org>
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> 
> Note: Not tested. Please test/review.
> 
> Signed-off-by: Allen Pais <allen.lkml@...il.com>
> ---
>  drivers/s390/block/dasd.c              | 42 ++++++++++++------------
>  drivers/s390/block/dasd_int.h          | 10 +++---
>  drivers/s390/char/con3270.c            | 27 ++++++++--------
>  drivers/s390/crypto/ap_bus.c           | 24 +++++++-------
>  drivers/s390/crypto/ap_bus.h           |  2 +-
>  drivers/s390/crypto/zcrypt_msgtype50.c |  2 +-
>  drivers/s390/crypto/zcrypt_msgtype6.c  |  4 +--
>  drivers/s390/net/ctcm_fsms.c           |  4 +--
>  drivers/s390/net/ctcm_main.c           | 15 ++++-----
>  drivers/s390/net/ctcm_main.h           |  5 +--
>  drivers/s390/net/ctcm_mpc.c            | 12 +++----
>  drivers/s390/net/ctcm_mpc.h            |  7 ++--
>  drivers/s390/net/lcs.c                 | 26 +++++++--------
>  drivers/s390/net/lcs.h                 |  2 +-
>  drivers/s390/net/qeth_core_main.c      |  2 +-
>  drivers/s390/scsi/zfcp_qdio.c          | 45 +++++++++++++-------------
>  drivers/s390/scsi/zfcp_qdio.h          |  9 +++---
>  17 files changed, 117 insertions(+), 121 deletions(-)
> 


We're looking into the best way to test this. 

For drivers/s390/net/ctcm* and drivers/s390/net/lcs*:
Acked-by: Alexandra Winter <wintera@...ux.ibm.com>


[...]
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index a0cce6872075..10ea95abc753 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -2911,7 +2911,7 @@ static int qeth_init_input_buffer(struct qeth_card *card,
>  	}
>  
>  	/*
> -	 * since the buffer is accessed only from the input_tasklet
> +	 * since the buffer is accessed only from the input_work
>  	 * there shouldn't be a need to synchronize; also, since we use
>  	 * the QETH_IN_BUF_REQUEUE_THRESHOLD we should never run  out off
>  	 * buffers

I propose to delete the whole comment block. There have been many changes and 
I don't think it is helpful for the current qeth driver.