netdev - Re: [net-next v2 2/2] mlx5/core: Support max_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402081836.30912d2c@kernel.org>
Date: Tue, 2 Apr 2024 08:18:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parav Pandit <parav@...dia.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <corbet@....net>,
 <kalesh-anakkur.purayil@...adcom.com>, <saeedm@...dia.com>,
 <leon@...nel.org>, <jiri@...nulli.us>, <shayd@...dia.com>,
 <danielj@...dia.com>, <dchumak@...dia.com>, <linux-doc@...r.kernel.org>,
 <linux-rdma@...r.kernel.org>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [net-next v2 2/2] mlx5/core: Support max_io_eqs for a function

On Tue, 2 Apr 2024 14:25:49 +0300 Parav Pandit wrote:
> +	query_ctx = kzalloc(query_out_sz, GFP_KERNEL);
> +	if (!query_ctx)
> +		return -ENOMEM;
> +
> +	mutex_lock(&esw->state_lock);
> +	err = mlx5_vport_get_other_func_cap(esw->dev, vport_num, query_ctx,
> +					    MLX5_CAP_GENERAL);
> +	if (err) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed getting HCA caps");
> +		goto out;

missing unlock

And before someone suggests we need guards, even make coccicheck catches
this...

> +	}
> +
> +	hca_caps = MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability);
> +	MLX5_SET(cmd_hca_cap, hca_caps, max_num_eqs, max_eqs);
> +
> +	err = mlx5_vport_set_other_func_cap(esw->dev, hca_caps, vport_num,
> +					    MLX5_SET_HCA_CAP_OP_MOD_GENERAL_DEVICE);
> +	mutex_unlock(&esw->state_lock);
> +	if (err)
> +		NL_SET_ERR_MSG_MOD(extack, "Failed setting HCA caps");
> +
> +out:
> +	kfree(query_ctx);
> +	return err;
-- 
pw-bot: cr