netdev - Re: [PATCH net-next] tcp: get rid of sysctl_tcp_adv_win

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6a198ec2d3c4bb5dc16ebd6c073588b@tesaguri.club>
Date: Tue, 02 Apr 2024 12:29:28 -0400
From: shironeko@...aguri.club
To: Eric Dumazet <edumazet@...gle.com>
Cc: Jose Alonso <joalonsof@...il.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, Soheil Hassas Yeganeh
 <soheil@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, Yuchung Cheng
 <ycheng@...gle.com>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: get rid of sysctl_tcp_adv_win_scale

On 2024-04-02 12:23, Eric Dumazet wrote:
> 
> Could you try this patch ?
> 
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index 88e084534853dd50505fd730e7ccd07c70f2d8ee..ca33365e49cc3993a974ddbdbf68189ce4df2e82
> 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1452,21 +1452,16 @@ static int ax88179_rx_fixup(struct usbnet
> *dev, struct sk_buff *skb)
>                         /* Skip IP alignment pseudo header */
>                         skb_pull(skb, 2);
> 
> -                       skb->truesize = SKB_TRUESIZE(pkt_len_plus_padd);
>                         ax88179_rx_checksum(skb, pkt_hdr);
>                         return 1;
>                 }
> 
> -               ax_skb = skb_clone(skb, GFP_ATOMIC);
> +               ax_skb = netdev_alloc_skb_ip_align(dev->net, pkt_len);
>                 if (!ax_skb)
>                         return 0;
> -               skb_trim(ax_skb, pkt_len);
> +               skb_put(ax_skb, pkt_len);
> +               memcpy(ax_skb->data, skb->data + 2, pkt_len);
> 
> -               /* Skip IP alignment pseudo header */
> -               skb_pull(ax_skb, 2);
> -
> -               skb->truesize = pkt_len_plus_padd +
> -                               SKB_DATA_ALIGN(sizeof(struct sk_buff));
>                 ax88179_rx_checksum(ax_skb, pkt_hdr);
>                 usbnet_skb_return(dev, ax_skb);

will report back next week :)