netdev - Re: [PATCH net-next] net: fman: Remove some unused fields in some structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ef3f80-77aa-4833-b74e-a2e950bac442@seco.com>
Date: Tue, 2 Apr 2024 15:06:52 -0400
From: Sean Anderson <sean.anderson@...o.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Madalin Bucur <madalin.bucur@....com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: fman: Remove some unused fields in some
 structure

On 4/2/24 14:55, Christophe JAILLET wrote:
> In "struct muram_info", the 'size' field is unused.
> In "struct memac_cfg", the 'fixed_link' field is unused.
>
> Remove them.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
>
> For fman_memac.c, I think that it is a left-over from commit 5d93cfcf7360
> ("net: dpaa: Convert to phylink").
> Maybe, #include <linux/phy_fixed.h> can be removed too, but it is not the
> purpose of this patch.
> ---
>  drivers/net/ethernet/freescale/fman/fman_memac.c | 1 -
>  drivers/net/ethernet/freescale/fman/fman_muram.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
> index 758535adc9ff..92b8f4ab26f1 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -267,7 +267,6 @@ struct memac_cfg {
>       bool reset_on_init;
>       bool pause_ignore;
>       bool promiscuous_mode_enable;
> -     struct fixed_phy_status *fixed_link;
>       u16 max_frame_length;
>       u16 pause_quanta;
>       u32 tx_ipg_length;
> diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c b/drivers/net/ethernet/freescale/fman/fman_muram.c
> index f557d68e5b76..1ed245a2ee01 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_muram.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_muram.c
> @@ -12,7 +12,6 @@
>  struct muram_info {
>       struct gen_pool *pool;
>       void __iomem *vbase;
> -     size_t size;
>       phys_addr_t pbase;
>  };
>

Reviewed-by: Sean Anderson <sean.anderson@...o.com>

[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>