netdev - Re: [PATCH v3 net-next 2/6] net: phy: realtek: add get_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Apr 2024 20:24:44 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Behún <kabel@...nel.org>,
	Frank Wunderlich <frank-w@...lic-files.de>,
	Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 2/6] net: phy: realtek: add
 get_rate_matching() for rtl822xb PHYs

On Tue, Apr 02, 2024 at 07:58:44AM +0200, Eric Woudstra wrote:
> +	switch (val & RTL822X_VND1_SERDES_OPTION_MODE_MASK) {
> +	case RTL822X_VND1_SERDES_OPTION_MODE_2500BASEX:
> +		return RATE_MATCH_PAUSE;
> +	/* case RTL822X_VND1_SERDES_OPTION_MODE_2500BASEX_SGMII: */
> +	default:
> +		return RATE_MATCH_NONE;
> +	}

Nit: Is this actually useful to have as a switch statement?

In any case,

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!