netdev - Re: [PATCH net-next v3 1/3] ethtool: provide customized dim profile management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 04:11:17 +0800
From: kernel test robot <lkp@...el.com>
To: Heng Qi <hengqi@...ux.alibaba.com>, netdev@...r.kernel.org,
	virtualization@...ts.linux.dev
Cc: oe-kbuild-all@...ts.linux.dev, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH net-next v3 1/3] ethtool: provide customized dim profile
 management

Hi Heng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/ethtool-provide-customized-dim-profile-management/20240402-201527
base:   net-next/main
patch link:    https://lore.kernel.org/r/1712059988-7705-2-git-send-email-hengqi%40linux.alibaba.com
patch subject: [PATCH net-next v3 1/3] ethtool: provide customized dim profile management
config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240403/202404030318.707Oc9CJ-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240403/202404030318.707Oc9CJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404030318.707Oc9CJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/ethtool/coalesce.c:363: warning: Function parameter or struct member 'extack' not described in 'ethnl_update_profile'


vim +363 net/ethtool/coalesce.c

   340	
   341	/**
   342	 * ethnl_update_profile - get a nla nest with four child nla nests from userspace.
   343	 * @dst: data get from the driver and modified by ethnl_update_profile.
   344	 * @nests: nest attr ETHTOOL_A_COALESCE_*X_*QE_PROFILE to set driver's profile.
   345	 * @mod: whether the data is modified
   346	 *
   347	 * Layout of nests:
   348	 *   Nested ETHTOOL_A_COALESCE_*X_*QE_PROFILE attr
   349	 *     Nested ETHTOOL_A_MODERATIONS_MODERATION attr
   350	 *       ETHTOOL_A_MODERATION_USEC attr
   351	 *       ETHTOOL_A_MODERATION_PKTS attr
   352	 *       ETHTOOL_A_MODERATION_COMPS attr
   353	 *     ...
   354	 *     Nested ETHTOOL_A_MODERATIONS_MODERATION attr
   355	 *       ETHTOOL_A_MODERATION_USEC attr
   356	 *       ETHTOOL_A_MODERATION_PKTS attr
   357	 *       ETHTOOL_A_MODERATION_COMPS attr
   358	 */
   359	static inline void ethnl_update_profile(struct dim_cq_moder *dst,
   360						const struct nlattr *nests,
   361						bool *mod,
   362						struct netlink_ext_ack *extack)
 > 363	{
   364		struct nlattr *tb_moder[ARRAY_SIZE(coalesce_set_profile_policy)];
   365		struct dim_cq_moder profs[NET_DIM_PARAMS_NUM_PROFILES];
   366		struct nlattr *nest;
   367		int ret, rem, i = 0;
   368	
   369		if (!nests)
   370			return;
   371	
   372		nla_for_each_nested(nest, nests, rem) {
   373			if (WARN_ONCE(nla_type(nest) != ETHTOOL_A_MODERATIONS_MODERATION,
   374				      "unexpected nest attrtype %u\n", nla_type(nest)))
   375				return;
   376	
   377			ret = nla_parse_nested(tb_moder,
   378					       ARRAY_SIZE(coalesce_set_profile_policy) - 1,
   379					       nest, coalesce_set_profile_policy,
   380					       extack);
   381			if (ret ||
   382			    !tb_moder[ETHTOOL_A_MODERATION_USEC] ||
   383			    !tb_moder[ETHTOOL_A_MODERATION_PKTS] ||
   384			    !tb_moder[ETHTOOL_A_MODERATION_COMPS]) {
   385				NL_SET_ERR_MSG(extack, "wrong ETHTOOL_A_MODERATION_* attribute\n");
   386				return;
   387			}
   388	
   389			profs[i].usec = nla_get_u16(tb_moder[ETHTOOL_A_MODERATION_USEC]);
   390			profs[i].pkts = nla_get_u16(tb_moder[ETHTOOL_A_MODERATION_PKTS]);
   391			profs[i].comps = nla_get_u16(tb_moder[ETHTOOL_A_MODERATION_COMPS]);
   392	
   393			if (dst[i].usec != profs[i].usec || dst[i].pkts != profs[i].pkts ||
   394			    dst[i].comps != profs[i].comps)
   395				*mod = true;
   396	
   397			i++;
   398		}
   399	
   400		memcpy(dst, profs, sizeof(profs));
   401	}
   402	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki