netdev - Re: [PATCH v7] posix-timers: add clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877chfcrx3.ffs@tglx>
Date: Wed, 03 Apr 2024 00:37:28 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
Cc: Sagi Maimon <maimon.sagi@...il.com>, richardcochran@...il.com,
 luto@...nel.org, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, arnd@...db.de,
 geert@...ux-m68k.org, peterz@...radead.org, hannes@...xchg.org,
 sohil.mehta@...el.com, rick.p.edgecombe@...el.com, nphamcs@...il.com,
 palmer@...ive.com, keescook@...omium.org, legion@...nel.org,
 mark.rutland@....com, mszeredi@...hat.com, casey@...aufler-ca.com,
 reibax@...il.com, davem@...emloft.net, brauner@...nel.org,
 linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
 linux-arch@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v7] posix-timers: add clock_compare system call

On Tue, Apr 02 2024 at 14:16, Mahesh Bandewar (महेश बंडेवार) wrote:
> On Tue, Apr 2, 2024 at 2:25 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>> Works as well. I'm not seing the point for CLOCK_MONOTONIC and the
>> change logs are not really telling anything about the problem being
>> solved....
>>
> https://lore.kernel.org/lkml/20240104212431.3275688-1-maheshb@google.com/T/#:~:text=*%20[PATCHv3%20net%2Dnext%200/3]%20add%20ptp_gettimex64any()%20API,21:24%20Mahesh%20Bandewar%200%20siblings%2C%200%20replies;
>
> This is the cover letter where I tried to explain the need for this.

The justification for a patch needs to be in the change log and not in
the cover letter because the cover letter is not part of the git
history.

> Granted, my current use case is for CLOCK_MONOTONIC_RAW but just
> because I don't have a use case doesn't mean someone else may not have
> it and hence added it.

Then why did you not five other clock IDs? Someone else might have a
use case, no?

While a syscall/ioctl should be flexible for future use, the kernel does
not add features just because there might be some use case. It's
documented how this works.

Thanks,

        tglx