[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f20d1e2a2f5fa10f29bf1fddbaf99c3f185e8530.camel@gmail.com>
Date: Wed, 03 Apr 2024 02:40:19 +0300
From: Eduard Zingerman <eddyz87@...il.com>
To: Pu Lehui <pulehui@...weicloud.com>, bpf@...r.kernel.org,
linux-riscv@...ts.infradead.org, netdev@...r.kernel.org
Cc: Björn Töpel <bjorn@...nel.org>, Alexei Starovoitov
<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko
<andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu
<song@...nel.org>, Yonghong Song <yhs@...com>, John Fastabend
<john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Stanislav
Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa
<jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, Manu Bretelle
<chantr4@...il.com>, Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH bpf-next 0/5] Support local vmtest for riscv64
On Sat, 2024-03-30 at 18:12 +0800, Pu Lehui wrote:
[...]
> > Looks like I won't be able to test this patch-set, unless you have
> > some writeup on how to create a riscv64 dev environment at hand.
> > Sorry for the noise
>
> Yeah, environmental issues are indeed a developer's nightmare. I will
> try to do something for the newcomers of riscv64 bpf. At present, I have
> simply built a docker local vmtest environment [0] based on Bjorn's
> riscv-cross-builder. We can directly run vmtest within this environment.
> Hopefully it will help.
>
> Link: https://github.com/pulehui/riscv-cross-builder/tree/vmtest [0]
Hi Pu,
Thank you for sharing the docker file, I've managed to run the tests
using it. In order to avoid creating files with root permissions I had
to add the following lines at the end of the Dockerfile:
+ RUN useradd --no-create-home --uid 1000 eddy
+ RUN passwd -d eddy
+ RUN echo 'eddy ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
+ # vmtest.sh does 'mount -o loop',
+ # ensure there is a loop device in the container
+ RUN mknod /dev/loop0 b 7 20
Where 'eddy' is my local user with UID 1000.
Probably this should be made more generic.
I used the following command to start the container:
docker run -ti -u 1000:1000 \
--rm -v <path-to-kernel-dir>:/workspace \
-v <path-to-rootfs-image-dir>:/rootfs \
--privileged ubuntu-vmtest:latest /bin/bash
Also, I had to add '-d /rootfs/bpf_selftests' option for vmtest.sh in
order to avoid polluting user directory inside the container.
Maybe OUTPUT_DIR for vmtest.sh should be mounted as a separate volume.
I agree with Daniel, it would be great to document all of this
somewhere in the repo (or even scripted somehow).
Using the specified DENYLIST I get the following stats for test_progs:
#3/2 arena_htab/arena_htab_asm:FAIL
#3 arena_htab:FAIL
#95 get_branch_snapshot:FAIL
#172/1 perf_branches/perf_branches_hw:FAIL
#172 perf_branches:FAIL
#434/3 verifier_arena/basic_alloc3:FAIL
#434 verifier_arena:FAIL
Summary: 531/3581 PASSED, 64 SKIPPED, 4 FAILED
Tested-by: Eduard Zingerman <eddyz87@...il.com>
> PS: Since the current rootfs of riscv64 is not in the INDEX, I simply
> modified vmtest.sh to support local rootfs.
Could you please add this change to the patch-set?
[...]
Powered by blists - more mailing lists