netdev - RE: [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate checks whether given VSI is main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA0PR11MB84191C97688B67FB04B11BF8BD3E2@IA0PR11MB8419.namprd11.prod.outlook.com>
Date: Tue, 2 Apr 2024 04:25:44 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: ivecera <ivecera@...hat.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Loktionov,
 Aleksandr" <aleksandr.loktionov@...el.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate
 checks whether given VSI is main

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Ivan Vecera
> Sent: Wednesday, March 27, 2024 1:28 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; edumazet@...gle.com; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate checks whether given VSI is main
>
> In the driver code there are 3 types of checks whether given VSI is main or not:
> 1. vsi->type ==/!= I40E_VSI_MAIN
> 2. vsi ==/!= pf->vsi[pf->lan_vsi]
> 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid
>
> All of them are equivalent and can be consolidated. Convert cases
> 2 and 3 to case 1.
>
> Reviewed-by: Michal Schmidt <mschmidt@...hat.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>  .../net/ethernet/intel/i40e/i40e_debugfs.c    |  2 +-
>  .../net/ethernet/intel/i40e/i40e_ethtool.c    | 12 ++++++------
>  drivers/net/ethernet/intel/i40e/i40e_main.c   | 19 +++++++++----------
>  3 files changed, 16 insertions(+), 17 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)