netdev - Re: [PATCH net-next v1 8/9] net: dsa: microchip: init predictable IPV to queue mapping for all non KSZ8xxx variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZguvOF6czMQg4iaF@pengutronix.de>
Date: Tue, 2 Apr 2024 09:09:44 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Arun.Ramadoss@...rochip.com
Cc: andrew@...n.ch, olteanv@...il.com, davem@...emloft.net,
	Woojung.Huh@...rochip.com, pabeni@...hat.com, edumazet@...gle.com,
	f.fainelli@...il.com, kuba@...nel.org, kernel@...gutronix.de,
	dsahern@...nel.org, san@...v.dk, willemb@...gle.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	horms@...nel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v1 8/9] net: dsa: microchip: init predictable
 IPV to queue mapping for all non KSZ8xxx variants

Hi Arun,

On Tue, Apr 02, 2024 at 04:07:30AM +0000, Arun.Ramadoss@...rochip.com wrote:
> Hi Oleksij,
> 
> On Thu, 2024-03-28 at 17:05 +0100, Oleksij Rempel wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> > 
> > Init priority to queue mapping in the way as it shown in IEEE 802.1Q
> > mapping example.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  drivers/net/dsa/microchip/ksz_common.c | 53 ++++++++++++++--------
> > ----
> >  1 file changed, 29 insertions(+), 24 deletions(-)
> > 
> > diff --git a/drivers/net/dsa/microchip/ksz_common.c
> > b/drivers/net/dsa/microchip/ksz_common.c
> > index 08426f85f7707..78e9610044ea8 100644
> > --- a/drivers/net/dsa/microchip/ksz_common.c
> > +++ b/drivers/net/dsa/microchip/ksz_common.c
> > @@ -24,6 +24,7 @@
> >  #include <linux/of_net.h>
> >  #include <linux/micrel_phy.h>
> >  #include <net/dsa.h>
> > +#include <net/ieee8021q.h>
> >  #include <net/pkt_cls.h>
> >  #include <net/switchdev.h>
> > 
> > @@ -2692,9 +2693,29 @@ static int ksz_port_mdb_del(struct dsa_switch
> > *ds, int port,
> >         return dev->dev_ops->mdb_del(dev, port, mdb, db);
> >  }
> > 
> > +static int ksz_set_default_prio_queue_mapping(struct ksz_device
> > *dev, int port)
> 
> Since this function is related to KSZ9477 series switch, do we need to
> move this function out of ksz_common.c or function name prefixed with
> ksz9477_set_default_prio_queue_mapping to differentiate it. 

Ack. Sounds good, will update it.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |