netdev - RE: [PATCH net] net: phy: micrel: lan8814: Fix when enabling/disabling 1-step timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB47719CB09438652F66E084F9E23E2@CO1PR11MB4771.namprd11.prod.outlook.com>
Date: Tue, 2 Apr 2024 07:55:28 +0000
From: <Divya.Koppera@...rochip.com>
To: <Horatiu.Vultur@...rochip.com>, <andrew@...n.ch>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <richardcochran@...il.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, <Horatiu.Vultur@...rochip.com>
Subject: RE: [PATCH net] net: phy: micrel: lan8814: Fix when
 enabling/disabling 1-step timestamping

> There are 2 issues with the blamed commit.
> 1. When the phy is initialized, it would enable the disabled of UDPv4
>    checksums. The UDPv6 checksum is already enabled by default. So when
>    1-step is configured then it would clear these flags.
> 2. After the 1-step is configured, then if 2-step is configured then the
>    1-step would be still configured because it is not clearing the flag.
>    So the sync frames will still have origin timestamps set.
> 
> Fix this by reading first the value of the register and then just change bit 12 as
> this one determines if the timestamp needs to be inserted in the frame,
> without changing any other bits.
> 
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---
>  drivers/net/phy/micrel.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Reviewed-by: Divya Koppera <divya.koppera@...rochip.com>