netdev - Re: [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zg1YZVtM3CZWDYq1@smile.fi.intel.com>
Date: Wed, 3 Apr 2024 16:23:49 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Corey Minyard <minyard@....org>
Cc: Arnd Bergmann <arnd@...nel.org>, linux-kernel@...r.kernel.org,
	Peter Huewe <peterhuewe@....de>,
	Jarkko Sakkinen <jarkko@...nel.org>, Vinod Koul <vkoul@...nel.org>,
	Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
	Xu Yilun <yilun.xu@...el.com>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Peter Rosin <peda@...ntia.se>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Iyappan Subramanian <iyappan@...amperecomputing.com>,
	Keyur Chudgar <keyur@...amperecomputing.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yisen Zhuang <yisen.zhuang@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>,
	Tony Lindgren <tony@...mide.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Xiang Chen <chenxiang66@...ilicon.com>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Russell King <linux@...linux.org.uk>,
	Jiri Slaby <jirislaby@...nel.org>,
	Jacky Huang <ychuang3@...oton.com>,
	Shan-Chun Hung <schung@...oton.com>, Arnd Bergmann <arnd@...db.de>,
	Jason Gunthorpe <jgg@...pe.ca>, Tom Rix <trix@...hat.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Randy Dunlap <rdunlap@...radead.org>, Rob Herring <robh@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	openipmi-developer@...ts.sourceforge.net,
	linux-integrity@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-fpga@...r.kernel.org, linux-input@...r.kernel.org,
	linux-i2c@...r.kernel.org, netdev@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR
 annotations

On Wed, Apr 03, 2024 at 07:47:49AM -0500, Corey Minyard wrote:
> On Wed, Apr 03, 2024 at 12:30:44PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 03, 2024 at 10:06:51AM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@...db.de>

...

> > > I considered splitting up the large patch into per subsystem patches, but since
> > > it's really just the same thing everywhere it feels better to do it all at once.
> > 
> > Can we split to three groups:
> > - Dropping ACPI_PTR()
> > - Dropping of_match_ptr() (which I won't review in depth, for example)
> > - Dropping both
> > ?
> 
> Why?

Easy to review ACPI parts independently on the rest. I think I explained that
in above. Besides that some patches might require additional work (don't remember
if it is the case for _this_ patch).

-- 
With Best Regards,
Andy Shevchenko