[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0f459fc1-1445-6e83-ace4-b2c42abfe884@iogearbox.net>
Date: Wed, 3 Apr 2024 16:40:38 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Pu Lehui <pulehui@...weicloud.com>, bpf@...r.kernel.org,
linux-riscv@...ts.infradead.org, netdev@...r.kernel.org
Cc: Björn Töpel <bjorn@...nel.org>,
Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
<eddyz87@...il.com>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
Jiri Olsa <jolsa@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH bpf-next v3 2/2] selftests/bpf: Add testcase where 7th
argment is struct
On 4/3/24 9:28 AM, Pu Lehui wrote:
> From: Pu Lehui <pulehui@...wei.com>
>
> Add testcase where 7th argument is struct for architectures with 8
> argument registers, and increase the complexity of the struct.
>
> Signed-off-by: Pu Lehui <pulehui@...wei.com>
> Acked-by: Björn Töpel <bjorn@...nel.org>
> Reviewed-by: Björn Töpel <bjorn@...osinc.com>
> ---
> tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 +
> .../selftests/bpf/bpf_testmod/bpf_testmod.c | 19 ++++++++++
> .../selftests/bpf/prog_tests/tracing_struct.c | 13 +++++++
> .../selftests/bpf/progs/tracing_struct.c | 35 +++++++++++++++++++
> 4 files changed, 68 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> index d8ade15e2789..639ee3f5bc74 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> @@ -6,6 +6,7 @@ kprobe_multi_test # needs CONFIG_FPROBE
> module_attach # prog 'kprobe_multi': failed to auto-attach: -95
> fentry_test/fentry_many_args # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
> fexit_test/fexit_many_args # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
> +tracing_struct # test_fentry:FAIL:tracing_struct__attach unexpected error: -524
Do we need to blacklist the whole test given it had coverage on arm64
before.. perhaps this test here could be done as a new subtest and only
that one is listed for arm64?
> fill_link_info/kprobe_multi_link_info # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> fill_link_info/kretprobe_multi_link_info # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> fill_link_info/kprobe_multi_invalid_ubuff # bpf_program__attach_kprobe_multi_opts unexpected error: -95
Thanks,
Daniel
Powered by blists - more mailing lists