[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iKS2nwhzP-z0xwD4_R21+_7UjY1ajUbA2mFFi_gJpLtzg@mail.gmail.com>
Date: Wed, 3 Apr 2024 18:00:52 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Ayush Sawal <ayush.sawal@...lsio.com>, "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Steffen Klassert <steffen.klassert@...unet.com>, Herbert Xu <herbert@...dor.apana.org.au>,
David Ahern <dsahern@...nel.org>, Boris Pismenny <borisp@...dia.com>,
John Fastabend <john.fastabend@...il.com>, Tariq Toukan <tariqt@...dia.com>,
Dragos Tatulea <dtatulea@...dia.com>, Simon Horman <horms@...nel.org>,
Sabrina Dubroca <sd@...asysnail.net>,
Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>,
Pavan Chebbi <pavan.chebbi@...adcom.com>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>, Yunsheng Lin <linyunsheng@...wei.com>,
Florian Westphal <fw@...len.de>, David Howells <dhowells@...hat.com>,
Alexander Lobakin <aleksander.lobakin@...el.com>, Lorenzo Bianconi <lorenzo@...nel.org>,
Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH net-next v4 1/3] net: make napi_frag_unref reuse skb_page_unref
On Wed, Apr 3, 2024 at 5:28 PM Mina Almasry <almasrymina@...gle.com> wrote:
>
> The implementations of these 2 functions are almost identical. Remove
> the implementation of napi_frag_unref, and make it a call into
> skb_page_unref so we don't duplicate the implementation.
>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists