netdev - Re: [net-next PATCH 04/15] eth: fbnic: Add register init to set PCIe/Ethernet device config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32deafeb-82fe-48c6-a15e-08e065963876@lunn.ch>
Date: Wed, 3 Apr 2024 22:46:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: netdev@...r.kernel.org, Alexander Duyck <alexanderduyck@...com>,
	kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com
Subject: Re: [net-next PATCH 04/15] eth: fbnic: Add register init to set
 PCIe/Ethernet device config

> +#define wr32(reg, val)	fbnic_wr32(fbd, reg, val)
> +#define rd32(reg)	fbnic_rd32(fbd, reg)
> +#define wrfl()		fbnic_rd32(fbd, FBNIC_MASTER_SPARE_0)

I don't think that is considered best practices, using variables not
passed to the macro.

	Andrew