netdev - Re: [PATCH net-next 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS2P194MB21702427C769FB68A13AF54B9A3C2@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM>
Date: Thu,  4 Apr 2024 18:14:12 +0200
From: Luigi Leonardi <luigi.leonardi@...look.com>
To: sgarzare@...hat.com
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	jasowang@...hat.com,
	kuba@...nel.org,
	kvm@...r.kernel.org,
	luigi.leonardi@...look.com,
	mst@...hat.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	stefanha@...hat.com,
	virtualization@...ts.linux.dev,
	xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports

Hi Stefano,
Thanks for the review.

>We incremented it only for VIRTIO_VSOCK_OP_RW, should we check the
>same here?

Checking for the length of the skbuf or checking for VIRTIO_VSOCK_OP_RW
AFAIK is equivalent. Since the only packet with payload is this one. 
I'll add a comment in v2 to make it more clear.

>What about rename it in `consume`?

Sounds good!

Thanks,
Luigi