netdev - Re: [PATCH v3 06/15] net: kunit: Suppress lock warning noise at end of dev_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403183412.16254318@kernel.org>
Date: Wed, 3 Apr 2024 18:34:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-kselftest@...r.kernel.org, David Airlie <airlied@...il.com>, Arnd
 Bergmann <arnd@...db.de>, Maíra Canal <mcanal@...lia.com>,
 Dan Carpenter <dan.carpenter@...aro.org>, Kees Cook
 <keescook@...omium.org>, Daniel Diaz <daniel.diaz@...aro.org>, David Gow
 <davidgow@...gle.com>, Arthur Grillo <arthurgrillo@...eup.net>, Brendan
 Higgins <brendan.higgins@...ux.dev>, Naresh Kamboju
 <naresh.kamboju@...aro.org>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Maxime Ripard <mripard@...nel.org>, Ville
 Syrjälä <ville.syrjala@...ux.intel.com>, Daniel Vetter
 <daniel@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 dri-devel@...ts.freedesktop.org, kunit-dev@...glegroups.com,
 linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
 linux-sh@...r.kernel.org, loongarch@...ts.linux.dev,
 netdev@...r.kernel.org, x86@...nel.org, Linux Kernel Functional Testing
 <lkft@...aro.org>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH v3 06/15] net: kunit: Suppress lock warning noise at end
 of dev_addr_lists tests

On Wed,  3 Apr 2024 06:19:27 -0700 Guenter Roeck wrote:
> dev_addr_lists_test generates lock warning noise at the end of tests
> if lock debugging is enabled. There are two sets of warnings.
> 
> WARNING: CPU: 0 PID: 689 at kernel/locking/mutex.c:923 __mutex_unlock_slowpath.constprop.0+0x13c/0x368
> DEBUG_LOCKS_WARN_ON(__owner_task(owner) != __get_current())
> 
> WARNING: kunit_try_catch/1336 still has locks held!
> 
> KUnit test cleanup is not guaranteed to run in the same thread as the test
> itself. For this test, this means that rtnl_lock() and rtnl_unlock() may
> be called from different threads. This triggers the warnings.
> Suppress the warnings because they are irrelevant for the test and just
> confusing and distracting.
> 
> The first warning can be suppressed by using START_SUPPRESSED_WARNING()
> and END_SUPPRESSED_WARNING() around the call to rtnl_unlock(). To suppress
> the second warning, it is necessary to set debug_locks_silent while the
> rtnl lock is held.

Is it okay if I move the locking into the tests, instead?
It's only 4 lines more and no magic required, seems to work fine.