netdev - Re: [PATCH net 1/1] s390/ism: fix receive message buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240405143641.GA5865@lst.de>
Date: Fri, 5 Apr 2024 16:36:41 +0200
From: Christoph Hellwig <hch@....de>
To: Niklas Schnelle <schnelle@...ux.ibm.com>
Cc: Gerd Bayer <gbayer@...ux.ibm.com>, Christoph Hellwig <hch@....de>,
	Paolo Abeni <pabeni@...hat.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Wen Gu <guwen@...ux.alibaba.com>,
	Heiko Carstens <hca@...ux.ibm.com>, pasic@...ux.ibm.com,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	Alexandra Winter <wintera@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH net 1/1] s390/ism: fix receive message buffer allocation

On Fri, Apr 05, 2024 at 01:29:55PM +0200, Niklas Schnelle wrote:
> Personally I'd go with a temporary variable here if only to make the
> lines a bit shorter and easier to read. I also think above is not
> correct for allocation failure since folio_address() accesses folio-
> >page without first checking for NULL. So I'm guessing the NULL check
> needs to move and be done on the temporary struct folio*.

Yes, it needs a local variable to NULL check the folio_alloc return.