netdev - RE: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime resume for ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB7522DF37FA0185E56DF02C27A0032@PH0PR11MB7522.namprd11.prod.outlook.com>
Date: Fri, 5 Apr 2024 20:41:15 +0000
From: "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>
To: Bjorn Helgaas <helgaas@...nel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: "Neftin, Sasha" <sasha.neftin@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Bjorn Helgaas
	<bhelgaas@...gle.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, Zheng Yan <zheng.z.yan@...el.com>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>, Heiner Kallweit
	<hkallweit1@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime
 resume for ethtool_ops

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Bjorn Helgaas
> Sent: Monday, March 25, 2024 3:30 PM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; David S . Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>
> Cc: Neftin, Sasha <sasha.neftin@...el.com>; netdev@...r.kernel.org; Wysocki, Rafael J <rafael.j.wysocki@...el.com>; linux-kernel@...r.kernel.org; Bjorn Helgaas <bhelgaas@...gle.com>; intel-wired-lan@...ts.osuosl.org; Zheng Yan <zheng.z.yan@...el.com>; Konstantin Khlebnikov <khlebnikov@...nvz.org>; Heiner Kallweit <hkallweit1@...il.com>
> Subject: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime resume for ethtool_ops
>
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> 749ab2cd1270 ("igb: add basic runtime PM support") added
> ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to
> resume suspended devices before any ethtool_ops callback and allow suspend
> after it completed.
>
> Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before
> ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path,
> so the device is resumed before any ethtool_ops callback even if the driver
> didn't supply a .begin() callback.
>
> Remove the .begin() and .complete() callbacks, which are now redundant
> because dev_ethtool() already resumes the device.
>
>Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
>---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mekala@...el.com> (A Contingent worker at Intel)