netdev - Re: [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for PTP_PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240405091623.yxbx5pkoxqqokyr2@DEN-DL-M31836.microchip.com>
Date: Fri, 5 Apr 2024 11:16:23 +0200
From: Horatiu Vultur - M31836 <Horatiu.Vultur@...rochip.com>
To: Divya Koppera - I30481 <Divya.Koppera@...rochip.com>
CC: "andrew@...n.ch" <andrew@...n.ch>, "hkallweit1@...il.com"
	<hkallweit1@...il.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "richardcochran@...il.com"
	<richardcochran@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, UNGLinuxDriver <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for
 PTP_PF_PEROUT

The 04/05/2024 08:35, Divya Koppera - I30481 wrote:
> Hi Horatiu,

Hi Divya,

> > +	ts_on.tv_sec = rq->perout.on.sec;
> > +	ts_on.tv_nsec = rq->perout.on.nsec;
> > +	on_nsec = timespec64_to_ns(&ts_on);
> > +
> > +	ts_period.tv_sec = rq->perout.period.sec;
> > +	ts_period.tv_nsec = rq->perout.period.nsec;
> > +	period_nsec = timespec64_to_ns(&ts_period);
> > +
> > +	if (period_nsec < 200) {
> > +		pr_warn_ratelimited("%s: perout period too small, minimum
> > is 200 nsec\n",
> > +				    phydev_name(phydev));
> > +		return -EOPNOTSUPP;
> > +	}
> 
> Unlock is Missing in above and below conditions.

Thanks for the review.

Jakob already mention this in a previous comment[1]. And I already sent a
new version where this is fixed.

[1] https://lore.kernel.org/netdev/20240404094137.51b1397e@kernel.org/T/#m3053305f9a354ebf89e4dd0e6140f6cfbd2591e6

> 
> > +
> > +	if (on_nsec >= period_nsec) {
> > +		pr_warn_ratelimited("%s: pulse width must be smaller than
> > period\n",
> > +				    phydev_name(phydev));
> > +		return -EINVAL;
> > +	}
> > +
-- 
/Horatiu