netdev - Re: [PATCH net-next] net: sched: cake: Optimize number of calls to cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frvxgnmr.fsf@toke.dk>
Date: Sun, 07 Apr 2024 18:10:04 +0200
From: Toke Høiland-Jørgensen <toke@...e.dk>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, jserv@...s.ncku.edu.tw, cake@...ts.bufferbloat.net,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Kuan-Wei Chiu
 <visitorckw@...il.com>
Subject: Re: [PATCH net-next] net: sched: cake: Optimize number of calls to
 cake_heapify()

Kuan-Wei Chiu <visitorckw@...il.com> writes:

> Improve the max-heap construction process by reducing unnecessary
> heapify operations. Specifically, adjust the starting condition from
> n / 2 to n / 2 - 1 in the loop that iterates over all non-leaf
> elements.

Please add an explanation for why this change is correct, and why it is
beneficial. "Improve" and "unnecessary" is way too implicit.

pw-bot: cr