netdev - Re: [PATCH net-next] ipv4: Set scope explicitly in ip_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240408105511.GD8764@unreal>
Date: Mon, 8 Apr 2024 13:55:11 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Guillaume Nault <gnault@...hat.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Mustafa Ismail <mustafa.ismail@...el.com>,
	Shiraz Saleem <shiraz.saleem@...el.com>,
	Jason Gunthorpe <jgg@...pe.ca>,
	Michal Kalderon <mkalderon@...vell.com>,
	Ariel Elior <aelior@...vell.com>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	David Ahern <dsahern@...nel.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Roopa Prabhu <roopa@...dia.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>
Subject: Re: [PATCH net-next] ipv4: Set scope explicitly in ip_route_output().

On Fri, Apr 05, 2024 at 10:05:00PM +0200, Guillaume Nault wrote:
> Add a "scope" parameter to ip_route_output() so that callers don't have
> to override the tos parameter with the RTO_ONLINK flag if they want a
> local scope.
> 
> This will allow converting flowi4_tos to dscp_t in the future, thus
> allowing static analysers to flag invalid interactions between
> "tos" (the DSCP bits) and ECN.
> 
> Only three users ask for local scope (bonding, arp and atm). The others
> continue to use RT_SCOPE_UNIVERSE. While there, add a comment to warn
> users about the limitations of ip_route_output().
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  drivers/infiniband/hw/irdma/cm.c        | 3 ++-
>  drivers/infiniband/hw/qedr/qedr_iw_cm.c | 3 ++-
>  drivers/net/bonding/bond_main.c         | 4 ++--
>  drivers/net/ethernet/broadcom/cnic.c    | 3 ++-
>  include/net/route.h                     | 9 ++++++++-
>  net/atm/clip.c                          | 2 +-
>  net/bridge/br_netfilter_hooks.c         | 3 ++-
>  net/ipv4/arp.c                          | 9 ++++++---
>  net/ipv4/igmp.c                         | 3 ++-
>  net/mpls/af_mpls.c                      | 2 +-
>  10 files changed, 28 insertions(+), 13 deletions(-)
> 

Thanks,
Acked-by: Leon Romanovsky <leonro@...dia.com> # infiniband