netdev - Re: [PATCH net-next v3 7/9] net: dsa: microchip: enable ETS support for KSZ989X variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d4afde2479cb7830c8add15a7df3d58db0dbb3c.camel@microchip.com>
Date: Mon, 8 Apr 2024 03:52:57 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<Woojung.Huh@...rochip.com>, <pabeni@...hat.com>, <o.rempel@...gutronix.de>,
	<edumazet@...gle.com>, <f.fainelli@...il.com>, <kuba@...nel.org>
CC: <kernel@...gutronix.de>, <dsahern@...nel.org>, <san@...v.dk>,
	<willemb@...gle.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <horms@...nel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v3 7/9] net: dsa: microchip: enable ETS support
 for KSZ989X variants

Hi Oleksij,

On Fri, 2024-04-05 at 11:52 +0200, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> I tested ETS support on KSZ9893, so it should work other KSZ989X
> variants too.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

nitpick: For the source code I infer ets support is support for all
switches except ksz8x family(KSZ8795/4, KSZ8765 and KSZ8830).
Instead of .tc_ets_supported, can we add in the ksz_tc_setup_qdisc_ets(
)
 like

if( ksz8_family())
	return -EOPNOTSUPP;

Otherwise
Acked-by: Arun Ramadoss <arun.ramadoss@...rochip.com>

> ---
>  drivers/net/dsa/microchip/ksz_common.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/ksz_common.c
> b/drivers/net/dsa/microchip/ksz_common.c
> index 840b17b8507e1..dc96931e62da8 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -1378,6 +1378,7 @@ const struct ksz_chip_data ksz_switch_chips[] =
> {
>                 .port_nirqs = 2,
>                 .num_tx_queues = 4,
>                 .num_ipvs = 8,
> +               .tc_ets_supported = true,
>                 .ops = &ksz9477_dev_ops,
>                 .mib_names = ksz9477_mib_names,
>                 .mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
> @@ -1411,6 +1412,7 @@ const struct ksz_chip_data ksz_switch_chips[] =
> {
>                 .port_nirqs = 2,
>                 .num_tx_queues = 4,
>                 .num_ipvs = 8,
> +               .tc_ets_supported = true,
>                 .ops = &ksz9477_dev_ops,
>                 .mib_names = ksz9477_mib_names,
>                 .mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
> @@ -1442,6 +1444,7 @@ const struct ksz_chip_data ksz_switch_chips[] =
> {
>                 .port_nirqs = 2,
>                 .num_tx_queues = 4,
>                 .num_ipvs = 8,
> +               .tc_ets_supported = true,
>                 .ops = &ksz9477_dev_ops,
>                 .mib_names = ksz9477_mib_names,
>                 .mib_cnt = ARRAY_SIZE(ksz9477_mib_names),
> --
> 2.39.2
>