netdev - Re: [PATCH v3 net] Subject: [PATCH] RDMA/core: fix UAF with ib_device_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240408142302.GC223006@ziepe.ca>
Date: Mon, 8 Apr 2024 11:23:02 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Denis Kirjanov <kirjanov@...il.com>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, leon@...nel.org,
	Denis Kirjanov <dkirjanov@...e.de>,
	syzbot+5fe14f2ff4ccbace9a26@...kaller.appspotmail.com
Subject: Re: [PATCH v3 net] Subject: [PATCH] RDMA/core: fix UAF with
 ib_device_get_netdev()

On Thu, Mar 28, 2024 at 09:35:42AM -0400, Denis Kirjanov wrote:
> A call to ib_device_get_netdev may lead to a race condition
> while accessing a netdevice instance since we don't hold
> the rtnl lock while checking
> the registration state:
> 	if (res && res->reg_state != NETREG_REGISTERED) {
> 
> v2: unlock rtnl on error path
> v3: update remaining callers of ib_device_get_netdev
> 
> Reported-by: syzbot+5fe14f2ff4ccbace9a26@...kaller.appspotmail.com
> Fixes: d41861942fc55 ("IB/core: Add generic function to extract IB speed from netdev")
> Signed-off-by: Denis Kirjanov <dkirjanov@...e.de>
> ---
>  drivers/infiniband/core/cache.c  |  2 ++
>  drivers/infiniband/core/device.c | 15 ++++++++++++---
>  drivers/infiniband/core/nldev.c  |  2 ++
>  drivers/infiniband/core/verbs.c  |  6 ++++--
>  4 files changed, 20 insertions(+), 5 deletions(-)

This is a rdma patch you need to cc linux-rdma and ensure it reaches
the rdma patchworks or it will not be applied..

Thanks,
Jason