netdev - Re: [PATCH net-next v3] net: phy: dp8382x: keep WOL settings across suspends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240408074352.GZ26556@kernel.org>
Date: Mon, 8 Apr 2024 08:43:52 +0100
From: Simon Horman <horms@...nel.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, m.felsch@...gutronix.de,
	bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH net-next v3] net: phy: dp8382x: keep WOL settings across
 suspends

On Thu, Apr 04, 2024 at 03:05:16PM +0200, Catalin Popescu wrote:
> Unlike other ethernet PHYs from TI, PHY dp8382x has WOL enabled
> at reset. The driver explicitly disables WOL in config_init callback
> which is called during init and during resume from suspend. Hence,
> WOL is unconditionally disabled during resume, even if it was enabled
> before the suspend. We make sure that WOL configuration is persistent
> across suspends.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---
> Changes in v3:
>  - rename function _dp83822_set_wol to dp83822_config_wol

Reviewed-by: Simon Horman <horms@...nel.org>