netdev - Re: [PATCH 1/2] ipv6: fib: hide unused 'pn' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Apr 2024 10:48:54 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>, 
	Breno Leitao <leitao@...ian.org>, Kui-Feng Lee <thinker.li@...il.com>, 
	Kunwu Chan <chentao@...inos.cn>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Ville Nuorvala <vnuorval@....hut.fi>, YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ipv6: fib: hide unused 'pn' variable

On Mon, Apr 8, 2024 at 9:42 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> When CONFIG_IPV6_SUBTREES is disabled, the only user is hidden, causing
> a 'make W=1' warning:
>
> net/ipv6/ip6_fib.c: In function 'fib6_add':
> net/ipv6/ip6_fib.c:1388:32: error: variable 'pn' set but not used [-Werror=unused-but-set-variable]
>
> Add another #ifdef around the variable declaration, matching the other
> uses in this file.
>
> Fixes: 66729e18df08 ("[IPV6] ROUTE: Make sure we have fn->leaf when adding a node on subtree.")
> Link: https://lore.kernel.org/netdev/20240322131746.904943-1-arnd@kernel.org/
> Reviewed-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

It is unfortunate we add an #ifdef just to avoid a warning.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>