netdev - RE: [Intel-wired-lan] [PATCH iwl-next v8 2/2] ice: Implement 'flow-type ether' rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CYYPR11MB8429492BCA718AFB2402218FBD002@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Mon, 8 Apr 2024 09:10:06 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Plachno, Lukasz" <lukasz.plachno@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>, "brett.creeley@....com"
	<brett.creeley@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Buchocki, JakubX" <jakubx.buchocki@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Plachno, Lukasz" <lukasz.plachno@...el.com>,
	"horms@...nel.org" <horms@...nel.org>, "Pacuszka, MateuszX"
	<mateuszx.pacuszka@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v8 2/2] ice: Implement
 'flow-type ether' rules

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Lukasz Plachno
> Sent: Wednesday, April 3, 2024 3:54 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: pmenzel@...gen.mpg.de; brett.creeley@....com; netdev@...r.kernel.org; Buchocki, JakubX <jakubx.buchocki@...el.com>; Lobakin, Aleksander <aleksander.lobakin@...el.com>; Plachno, Lukasz <lukasz.plachno@...el.com>; horms@...nel.org; Pacuszka, MateuszX <mateuszx.pacuszka@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v8 2/2] ice: Implement 'flow-type ether' rules
>
> From: Jakub Buchocki <jakubx.buchocki@...el.com>
>
> Add support for 'flow-type ether' Flow Director rules via ethtool.
>
> Create packet segment info for filter configuration based on ethtool command parameters. Reuse infrastructure already created for
> ipv4 and ipv6 flows to convert packet segment into extraction sequence, which is later used to program the filter inside Flow Director block of the Rx pipeline.
> 
> Rules not containing masks are processed by the Flow Director, and support the following set of input parameters in all combinations:
> src, dst, proto, vlan-etype, vlan, action.
>
> It is possible to specify address mask in ethtool parameters but only
> 00:00:00:00:00 and FF:FF:FF:FF:FF are valid.
> The same applies to proto, vlan-etype and vlan masks:
> only 0x0000 and 0xffff masks are valid.
>
> Testing:
>   (DUT) iperf3 -s
>   (DUT) ethtool -U ens785f0np0 flow-type ether dst <ens785f0np0 mac> \
>         action 10
>   (DUT) watch 'ethtool -S ens785f0np0 | grep rx_queue'
>   (LP)  iperf3 -c ${DUT_IP}
>
>   Counters increase only for:
>     'rx_queue_10_packets'
>     'rx_queue_10_bytes'
>
> Signed-off-by: Jakub Buchocki <jakubx.buchocki@...el.com>
> Co-developed-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com>
> Signed-off-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Lukasz Plachno <lukasz.plachno@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 138 +++++++++++++++++-
>  drivers/net/ethernet/intel/ice/ice_fdir.c     |  26 ++++
>  drivers/net/ethernet/intel/ice/ice_fdir.h     |   5 +
>  drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
>  4 files changed, 169 insertions(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)