netdev - Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240408093309.9447-A-hca@linux.ibm.com>
Date: Mon, 8 Apr 2024 11:33:09 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Allen Pais <apais@...ux.microsoft.com>
Cc: linux-kernel@...r.kernel.org, tj@...nel.org, keescook@...omium.org,
        vkoul@...nel.org, marcan@...can.st, sven@...npeter.dev,
        florian.fainelli@...adcom.com, rjui@...adcom.com,
        sbranden@...adcom.com, paul@...pouillou.net,
        Eugeniy.Paltsev@...opsys.com, manivannan.sadhasivam@...aro.org,
        vireshk@...nel.org, Frank.Li@....com, leoyang.li@....com,
        zw@...kernel.org, wangzhou1@...ilicon.com, haijie1@...wei.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, sean.wang@...iatek.com,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        afaerber@...e.de, logang@...tatee.com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr, andersson@...nel.org,
        konrad.dybcio@...aro.org, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        patrice.chotard@...s.st.com, linus.walleij@...aro.org, wens@...e.org,
        jernej.skrabec@...il.com, peter.ujfalusi@...il.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        jassisinghbrar@...il.com, mchehab@...nel.org,
        maintainers@...echerrydvr.com, aubin.constans@...rochip.com,
        ulf.hansson@...aro.org, manuel.lauss@...il.com,
        mirq-linux@...e.qmqm.pl, jh80.chung@...sung.com, oakad@...oo.com,
        hayashi.kunihiko@...ionext.com, mhiramat@...nel.org,
        brucechang@....com.tw, HaraldWelte@...tech.com, pierre@...man.eu,
        duncan.sands@...e.fr, stern@...land.harvard.edu, oneukum@...e.com,
        openipmi-developer@...ts.sourceforge.net, dmaengine@...r.kernel.org,
        asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        imx@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
        linux-mediatek@...ts.infradead.org, linux-actions@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

On Wed, Mar 27, 2024 at 04:03:12PM +0000, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/infiniband/* from tasklet to BH workqueue.
> 
> Based on the work done by Tejun Heo <tj@...nel.org>
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10

I guess this dependency is a hard requirement due to commit 134874e2eee9
("workqueue: Allow cancel_work_sync() and disable_work() from atomic contexts
on BH work items")?

> ---
>  drivers/s390/block/dasd.c              | 42 ++++++++++++------------
>  drivers/s390/block/dasd_int.h          | 10 +++---
>  drivers/s390/char/con3270.c            | 27 ++++++++--------
>  drivers/s390/crypto/ap_bus.c           | 24 +++++++-------
>  drivers/s390/crypto/ap_bus.h           |  2 +-
>  drivers/s390/crypto/zcrypt_msgtype50.c |  2 +-
>  drivers/s390/crypto/zcrypt_msgtype6.c  |  4 +--
>  drivers/s390/net/ctcm_fsms.c           |  4 +--
>  drivers/s390/net/ctcm_main.c           | 15 ++++-----
>  drivers/s390/net/ctcm_main.h           |  5 +--
>  drivers/s390/net/ctcm_mpc.c            | 12 +++----
>  drivers/s390/net/ctcm_mpc.h            |  7 ++--
>  drivers/s390/net/lcs.c                 | 26 +++++++--------
>  drivers/s390/net/lcs.h                 |  2 +-
>  drivers/s390/net/qeth_core_main.c      |  2 +-
>  drivers/s390/scsi/zfcp_qdio.c          | 45 +++++++++++++-------------
>  drivers/s390/scsi/zfcp_qdio.h          |  9 +++---
>  17 files changed, 117 insertions(+), 121 deletions(-)

I'm asking since this patch comes with multiple compile errors. Probably due
to lack of cross compiler tool chain on your side.

If the above wouldn't be a hard dependency I'd say we could take those parts
of your patch which are fine into the s390 tree for 6.10, fix the rest, and
schedule that as well for 6.10 via the s390 tree.