netdev - RE: [PATCH net-next 3/6] flow_offload: add flow_rule_no_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM4PR13MB5882EFAFDD6ADBEEB19B1BA4E7072@DM4PR13MB5882.namprd13.prod.outlook.com>
Date: Tue, 9 Apr 2024 11:35:38 +0000
From: Baowen Zheng <baowen.zheng@...igine.com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Louis Peens
	<louis.peens@...igine.com>, Taras Chornyi <taras.chornyi@...ision.eu>,
	Woojung Huh <woojung.huh@...rochip.com>, "UNGLinuxDriver@...rochip.com"
	<UNGLinuxDriver@...rochip.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Yanguo Li
	<yanguo.li@...hogine.com>, oss-drivers <oss-drivers@...igine.com>, Andrew
 Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vladimir
 Oltean <olteanv@...il.com>, Edward Cree <ecree.xilinx@...il.com>, Jamal Hadi
 Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko
	<jiri@...nulli.us>
Subject: RE: [PATCH net-next 3/6] flow_offload: add
 flow_rule_no_control_flags()

>> On April 8, 2024 9:09 PM, Asbjørn wrote:
>>
>>> This helper can be used by drivers, that doesn't support any control
>>> flags, to reject any attempt to install rules with control flags.
>>>
>>> This is aimed at drivers, which uses flow_rule_match_control(), but
>>> doesn't implement any control flags.
>>>
>>> Only compile-tested.
>>>
>>> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
>>> ---
>>> include/net/flow_offload.h | 13 +++++++++++++
>>> 1 file changed, 13 insertions(+)
>>>
>>> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>>> index c1317b14da08c..415d225204a1f 100644
>>> --- a/include/net/flow_offload.h
>>> +++ b/include/net/flow_offload.h
>>> @@ -471,6 +471,19 @@ static inline bool
>>> flow_rule_no_unsupp_control_flags(const u32 supp_flags,
>>> 	return false;
>>> }
>>>
>>> +/**
>>> + * flow_rule_no_control_flags() - check for presence of any control
>>> +flags
>>> + * @flags: flags present in rule
>>> + * @extack: The netlink extended ACK for reporting errors.
>>> + *
>>> + * Returns true if no control flags are set, false otherwise.
>>> + */
>>> +static inline bool flow_rule_no_control_flags(const u32 flags,
>>> +					      struct netlink_ext_ack *extack) {
>>> +	return flow_rule_no_unsupp_control_flags(0, flags, extack); }
>>> +
>> How about to squash this change with series I patch since they have similar
>functions for driver to use.
>
>Do you have a link to the series, couldn't find it on the netdev list.
Sorry for confusing you. I mean if you can squash this change with your first patch which introduce the function of flow_rule_no_unsupp_control_flags.
>
>--
>Best regards
>Asbjørn Sloth Tønnesen
>Network Engineer
>Fiberby - AS42541