netdev - Re: [PATCH v4 net-next 1/6] net: phy: realtek: configure SerDes mode for rtl822xb PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <417f3e08-136b-47db-880b-c80aa5698c9b@lunn.ch>
Date: Tue, 9 Apr 2024 14:59:29 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Marek Behún <kabel@...nel.org>,
	Frank Wunderlich <frank-w@...lic-files.de>,
	Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org,
	Alexander Couzens <lynxis@...0.eu>,
	Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH v4 net-next 1/6] net: phy: realtek: configure SerDes mode
 for rtl822xb PHYs

On Tue, Apr 09, 2024 at 09:30:11AM +0200, Eric Woudstra wrote:
> From: Alexander Couzens <lynxis@...0.eu>
> 
> The rtl8221b and rtl8226b series support switching SerDes mode between
> 2500base-x and sgmii based on the negotiated copper speed.
> 
> Configure this switching mode according to SerDes modes supported by
> host.
> 
> There is an additional datasheet for RTL8226B/RTL8221B called
> "SERDES MODE SETTING FLOW APPLICATION NOTE" where a sequence is
> described to setup interface and rate adapter mode.
> 
> However, there is no documentation about the meaning of registers
> and bits, it's literally just magic numbers and pseudo-code.
> 
> Signed-off-by: Alexander Couzens <lynxis@...0.eu>
> [ refactored, dropped HiSGMII mode and changed commit message ]
> Signed-off-by: Marek Behún <kabel@...nel.org>
> [ changed rtl822x_update_interface() to use vendor register ]
> [ always fill in possible interfaces ]
> [ only apply to rtl8221b and rtl8226b phy's ]
> [ set phydev->rate_matching in .config_init() ]
> Signed-off-by: Eric Woudstra <ericwouds@...il.com>
> 
> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Hi Eric

The ordering of these tags should put your Signed-off-by last.
Reviewed-by: should come before them, without any blank lines. As the
patch makes it way towards mainline, each Maintainer will add a
Signed-off: by, and it is nice to keep them together.

This is not enough to need a respin, but please remember this for
future patches.

       Andrew