netdev - Re: [PATCH] net/socket: Ensure length of input socket option param >= sizeof(int)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cf0848b-f44c-42ad-848a-369a249bff77@gmail.com>
Date: Tue, 9 Apr 2024 15:07:41 +0200
From: Eric Dumazet <eric.dumazet@...il.com>
To: Edward Adam Davis <eadavis@...com>, pmenzel@...gen.mpg.de,
 edumazet@...gle.com
Cc: netdev@...r.kernel.org, johan.hedberg@...il.com,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 luiz.dentz@...il.com, marcel@...tmann.org,
 syzbot+d4ecae01a53fd9b42e7d@...kaller.appspotmail.com,
 syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] net/socket: Ensure length of input socket option param >=
 sizeof(int)


On 4/9/24 14:15, Edward Adam Davis wrote:
> The optlen value passed by syzbot to _sys_setsockopt() is 2, which results in
> only 2 bytes being allocated when allocating memory to kernel_optval, and the
> optval size passed when calling the function copy_from_sockptr() is 4 bytes.
> Here, optlen is determined uniformly in the entry function __sys_setsockopt().
> If its value is less than 4, the parameter is considered invalid.
>
> Reported-by: syzbot+837ba09d9db969068367@...kaller.appspotmail.com
> Reported-by: syzbot+b71011ec0a23f4d15625@...kaller.appspotmail.com
> Reported-by: syzbot+d4ecae01a53fd9b42e7d@...kaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@...com>


I think I gave my feedback already.

Please do not ignore maintainers feedback.

This patch is absolutely wrong.

Some setsockopt() deal with optlen == 1 just fine, thank you very much.