[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240409154345.7a2a73a5@kmaincent-XPS-13-7390>
Date: Tue, 9 Apr 2024 15:43:45 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Rob Herring <robh@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Luis Chamberlain
<mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, Greg
Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
<rafael@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown <broonie@...nel.org>,
Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner
Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
devicetree@...r.kernel.org, Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v6 14/17] dt-bindings: net: pse-pd: Add
bindings for PD692x0 PSE controller
On Tue, 2 Apr 2024 08:28:34 -0500
Rob Herring <robh@...nel.org> wrote:
> > + patternProperties:
> > + "^manager@0[0-9]|1[0-2]$":
>
> Unit-addresses are typically in hex.
>
> Is 'manager' something specific to this device or should be common?
Specific to this device.
> > + $ref: /schemas/graph.yaml#/properties/ports
>
> This is not using the graph binding. Furthermore, I don't want to see
> new cases of 'port' node names which are not graph nodes. We have it
> already with ethernet switches, but 'ethernet-port' is preferred over
> 'port'.
Ok I will remove the ref then.
> Why is this one 'managers' and the other device binding 'channels'?
Here each manager can have up to 8 ports.
The ports in tps23881 are called channels in the datasheet but I can use the
port naming for both if you prefer.
> > + description:
> > + PD69208T4/PD69204T4/PD69208M PSE manager exposing 4 or 8 physical
> > + ports.
> > +
> > + properties:
> > + reg:
> > + description:
> > + Incremental index of the PSE manager starting from 0, ranging
> > + from lowest to highest chip select, up to 12.
> > + maxItems: 1
> > +
> > + patternProperties:
> > + '^port@[0-7]$':
> > + type: object
> > + required:
> > + - reg
>
> Any property you want is allowed in this node. You are missing
> 'additionalProperties'.
Indeed.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Powered by blists - more mailing lists