netdev - Re: [PATCH net-next 2/3] net: dsa: allow DSA switch drivers to provide their own phylink mac ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Apr 2024 11:15:01 +0800
From: kernel test robot <lkp@...el.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/3] net: dsa: allow DSA switch drivers to
 provide their own phylink mac ops

Hi Russell,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-dsa-introduce-dsa_phylink_to_port/20240408-232316
base:   net-next/main
patch link:    https://lore.kernel.org/r/E1rtn25-0065p0-2C%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next 2/3] net: dsa: allow DSA switch drivers to provide their own phylink mac ops
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240409/202404091147.pdi8izJ3-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240409/202404091147.pdi8izJ3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404091147.pdi8izJ3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/dsa/port.c:1981:6: warning: unused variable 'port' [-Wunused-variable]
           int port = dp->index;
               ^
   1 warning generated.


vim +/port +1981 net/dsa/port.c

3a506cb7012a98 Russell King (Oracle  2024-04-08  1975) 
770375ff331111 Vladimir Oltean       2022-08-18  1976  int dsa_shared_port_link_register_of(struct dsa_port *dp)
57ab1ca2159717 Vivien Didelot        2017-10-26  1977  {
0e27921816ad99 Ioana Ciornei         2019-05-28  1978  	struct dsa_switch *ds = dp->ds;
e09e9873152e3f Vladimir Oltean       2022-08-18  1979  	bool missing_link_description;
e09e9873152e3f Vladimir Oltean       2022-08-18  1980  	bool missing_phy_mode;
3be98b2d5fbca3 Andrew Lunn           2020-04-14 @1981  	int port = dp->index;
0e27921816ad99 Ioana Ciornei         2019-05-28  1982  
e09e9873152e3f Vladimir Oltean       2022-08-18  1983  	dsa_shared_port_validate_of(dp, &missing_phy_mode,
e09e9873152e3f Vladimir Oltean       2022-08-18  1984  				    &missing_link_description);
e09e9873152e3f Vladimir Oltean       2022-08-18  1985  
e09e9873152e3f Vladimir Oltean       2022-08-18  1986  	if ((missing_phy_mode || missing_link_description) &&
e09e9873152e3f Vladimir Oltean       2022-08-18  1987  	    !of_device_compatible_match(ds->dev->of_node,
e09e9873152e3f Vladimir Oltean       2022-08-18  1988  					dsa_switches_apply_workarounds))
e09e9873152e3f Vladimir Oltean       2022-08-18  1989  		return -EINVAL;
e09e9873152e3f Vladimir Oltean       2022-08-18  1990  
a20f997010c4ec Andrew Lunn           2020-03-11  1991  	if (!ds->ops->adjust_link) {
e09e9873152e3f Vladimir Oltean       2022-08-18  1992  		if (missing_link_description) {
e09e9873152e3f Vladimir Oltean       2022-08-18  1993  			dev_warn(ds->dev,
e09e9873152e3f Vladimir Oltean       2022-08-18  1994  				 "Skipping phylink registration for %s port %d\n",
e09e9873152e3f Vladimir Oltean       2022-08-18  1995  				 dsa_port_is_cpu(dp) ? "CPU" : "DSA", dp->index);
e09e9873152e3f Vladimir Oltean       2022-08-18  1996  		} else {
3a506cb7012a98 Russell King (Oracle  2024-04-08  1997) 			dsa_shared_port_link_down(dp);
e09e9873152e3f Vladimir Oltean       2022-08-18  1998  
770375ff331111 Vladimir Oltean       2022-08-18  1999  			return dsa_shared_port_phylink_register(dp);
3be98b2d5fbca3 Andrew Lunn           2020-04-14  2000  		}
a20f997010c4ec Andrew Lunn           2020-03-11  2001  		return 0;
a20f997010c4ec Andrew Lunn           2020-03-11  2002  	}
0e27921816ad99 Ioana Ciornei         2019-05-28  2003  
0e27921816ad99 Ioana Ciornei         2019-05-28  2004  	dev_warn(ds->dev,
0e27921816ad99 Ioana Ciornei         2019-05-28  2005  		 "Using legacy PHYLIB callbacks. Please migrate to PHYLINK!\n");
0e27921816ad99 Ioana Ciornei         2019-05-28  2006  
33615367f378fe Sebastian Reichel     2018-01-23  2007  	if (of_phy_is_fixed_link(dp->dn))
770375ff331111 Vladimir Oltean       2022-08-18  2008  		return dsa_shared_port_fixed_link_register_of(dp);
33615367f378fe Sebastian Reichel     2018-01-23  2009  	else
770375ff331111 Vladimir Oltean       2022-08-18  2010  		return dsa_shared_port_setup_phy_of(dp, true);
33615367f378fe Sebastian Reichel     2018-01-23  2011  }
57ab1ca2159717 Vivien Didelot        2017-10-26  2012  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki