netdev - Re: [PATCH net-next v3 6/6] rstreason: make it work in trace world

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409113846.5559359a@gandalf.local.home>
Date: Tue, 9 Apr 2024 11:38:46 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 dsahern@...nel.org, matttbe@...nel.org, martineau@...nel.org,
 geliang@...nel.org, mptcp@...ts.linux.dev,
 linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org, Jason Xing
 <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v3 6/6] rstreason: make it work in trace world

On Tue,  9 Apr 2024 18:09:34 +0800
Jason Xing <kerneljasonxing@...il.com> wrote:

>  /*
>   * tcp event with arguments sk and skb
> @@ -74,20 +75,38 @@ DEFINE_EVENT(tcp_event_sk_skb, tcp_retransmit_skb,
>  	TP_ARGS(sk, skb)
>  );
>  
> +#undef FN1
> +#define FN1(reason)	TRACE_DEFINE_ENUM(SK_RST_REASON_##reason);
> +#undef FN2
> +#define FN2(reason)	TRACE_DEFINE_ENUM(SKB_DROP_REASON_##reason);
> +DEFINE_RST_REASON(FN1, FN1)

Interesting. I've never seen the passing of the internal macros to the main
macro before. I see that you are using it for handling both the
SK_RST_REASON and the SK_DROP_REASON.

> +
> +#undef FN1
> +#undef FNe1
> +#define FN1(reason)	{ SK_RST_REASON_##reason, #reason },
> +#define FNe1(reason)	{ SK_RST_REASON_##reason, #reason }
> +
> +#undef FN2
> +#undef FNe2
> +#define FN2(reason)	{ SKB_DROP_REASON_##reason, #reason },
> +#define FNe2(reason)	{ SKB_DROP_REASON_##reason, #reason }

Anyway, from a tracing point of view, as it looks like it would work
(I haven't tested it).

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve