netdev - Re: [PATCH net-next] net: ethernet: Move eth_*_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409145835.71c0ef8e@kernel.org>
Date: Tue, 9 Apr 2024 14:58:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Diogo Ivo <diogo.ivo@...mens.com>, aleksander.lobakin@...el.com
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, jan.kiszka@...mens.com
Subject: Re: [PATCH net-next] net: ethernet: Move eth_*_addr_base to global
 symbols

On Tue,  9 Apr 2024 17:07:18 +0100 Diogo Ivo wrote:
> Promote IPv4/6 and Ethernet reserved base addresses to global symbols
> to avoid local copies being created when these addresses are referenced.

Did someone bloat-o-meter this?
I agree it's odd but the values are tiny and I'd expect compiler 
to eliminate the dead instances.
I mean, the instances are literally smaller than a pointer we'll
need to refer to them, if they can be inlined..