netdev - Re: [PATCH v24 00/20] nvme-tcp receive offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240409155907.2726de60@kernel.org>
Date: Tue, 9 Apr 2024 15:59:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>
Cc: Sagi Grimberg <sagi@...mberg.me>, Aurelien Aptel <aaptel@...dia.com>,
 "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "hch@....de"
 <hch@....de>, "kbusch@...nel.org" <kbusch@...nel.org>, "axboe@...com"
 <axboe@...com>, "davem@...emloft.net" <davem@...emloft.net>,
 "aurelien.aptel@...il.com" <aurelien.aptel@...il.com>, Shai Malin
 <smalin@...dia.com>, "malin1024@...il.com" <malin1024@...il.com>, Or
 Gerlitz <ogerlitz@...dia.com>, Yoray Zack <yorayz@...dia.com>, Boris
 Pismenny <borisp@...dia.com>, Gal Shalom <galshalom@...dia.com>, Max
 Gurtovoy <mgurtovoy@...dia.com>, "edumazet@...gle.com"
 <edumazet@...gle.com>
Subject: Re: [PATCH v24 00/20] nvme-tcp receive offloads

On Tue, 9 Apr 2024 22:35:51 +0000 Chaitanya Kulkarni wrote:
> blktests seems to be the right framework to add all the testcases to 
> cover the targeted subsystem(s) for this patchset. Daniel from Suse has 
> already posted an RFC (see [1]) to add support for blktests so we can  
> use real controllers for better test coverage. We will be discussing  
> that at LSFMM session this year in detail.

No preference on the framework or where the tests live, FWIW.

> With this support in the blktest framework, we can definitely generate  
> right test-coverage for the tcp-offload that can be run by anyone who  
> has this H/W. Just like I run NVMe tests on the code going from NVMe  
> tree to block tree for every pull request, we are planning to run new  
> nvme tcp offload specific tests regularly on NVMe tree. We will be happy 
> to provide the H/W to distros who are supporting this feature in order 
> to make testing easier for others as well.

You're not sending these patches to the distros, you're sending them
to the upstream Linux kernel. And unfortunately we don't have a test
lab where we could put your HW, so it's on you. To be clear all you
need to do is periodically build and test certain upstream branches 
and report results. By "report" all I mean is put a JSON file with the
result somewhere we can HTTP GET. KernelCI has been around for a while,
I don't think this is a crazy ask.