netdev - Re: [PATCH net-next 1/7] bnxt_en: Skip ethtool RSS context configuration in ifdown state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLi=8wuyNxkmVYQjb2O2Vsb74zVc3QmDVZ9hchdDedY0gMA@mail.gmail.com>
Date: Tue, 9 Apr 2024 16:51:49 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, pavan.chebbi@...adcom.com, 
	andrew.gospodarek@...adcom.com, 
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, 
	Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next 1/7] bnxt_en: Skip ethtool RSS context
 configuration in ifdown state

On Tue, Apr 9, 2024 at 4:26 PM Jacob Keller <jacob.e.keller@...el.com> wrote:
>
>
>
> On 4/9/2024 2:54 PM, Michael Chan wrote:
> > From: Pavan Chebbi <pavan.chebbi@...adcom.com>
> >
> > The current implementation requires the ifstate to be up when
> > configuring the RSS contexts.  It will try to fetch the RX ring
> > IDs and will crash if it is in ifdown state.  Return error if
> > !netif_running() to prevent the crash.
> >
> > An improved implementation is in the works to allow RSS contexts
> > to be changed while in ifdown state.
> >
> > Fixes: b3d0083caf9a ("bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()")
> > Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> > Reviewed-by: Somnath Kotur <somnath.kotur@...adcom.com>
> > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> > ---
>
> Makes sense, though I think you could send this fix directly to net as
> its clearly a bug fix and preventing a crash is good.

This RSS context feature in the driver is new and is only in net-next,
so the patch only applies to net-next.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)