netdev - Re: [PATCH v1 net 3/3] af_unix: Prepare MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240410002708.66697-1-kuniyu@amazon.com>
Date: Tue, 9 Apr 2024 17:27:08 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <rao.shoaib@...cle.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH v1 net 3/3] af_unix: Prepare MSG_OOB deprecation.

From: Rao Shoaib <rao.shoaib@...cle.com>
Date: Tue, 9 Apr 2024 17:09:24 -0700
> This feature was added because it was needed by Oracle products.

I know.  What's about now ?

I just took the silence as no here.
https://lore.kernel.org/netdev/472044aa-4427-40f0-9b9a-bce75d5c8aac@oracle.com/

As I noted in the cover letter, I'm fine to drop this patch if there's
a real user.

> The 
> bugs found are corner cases and happen with new feature, at the time all 
> tests passed.

Yes, but the test was not sufficient.

> If you do not feel like fixing these bugs that is fine, 
> let me know and I will address them,

Please do even if I don't let you know.

> but removing the feature completely 
> should not be an option.
> 
> Plus Amazon has it's own closed/proprietary distribution. If this is an 
> issue please configure your repo to not include this feature. Many 
> distributions choose not to include several features.

The problem is that the buggy feature risks many distributions.
If not-well-maintained feature is really needed only for a single
distro, it should be rather maintained as downstream patch.

If no one is using it, no reason to keep the attack sarface alive.