netdev - Re: [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <365ac7cd-7a93-4e48-a2b7-9db3a6432ff4@gmail.com>
Date: Wed, 10 Apr 2024 15:00:29 +0200
From: Richard Gobert <richardbgobert@...il.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to
 napi_gro_cb

Willem de Bruijn wrote:
> Richard Gobert wrote:
>> This patch adds network_offset and inner_network_offset to napi_gro_cb, and
>> makes sure both are set correctly. In the common path there's only one
>> write (skb_gro_reset_offset).
>>
>> Signed-off-by: Richard Gobert <richardbgobert@...il.com>
>> ---
>>  include/net/gro.h      | 18 ++++++++++++++++--
>>  net/8021q/vlan_core.c  |  2 ++
>>  net/core/gro.c         |  1 +
>>  net/ethernet/eth.c     |  1 +
>>  net/ipv4/af_inet.c     |  5 +----
>>  net/ipv4/gre_offload.c |  1 +
>>  net/ipv6/ip6_offload.c |  8 ++++----
> 
> Should this cover more protocols, like geneve, ipsec?

Yes, my bad. It should be added to geneve, ipsec and vxlan too. I'll
double-check and post v6.