netdev - Re: [PATCH net-next v5 02/10] net: free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zhaqyyk9CUaUvMDy@shredder>
Date: Wed, 10 Apr 2024 18:05:47 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Breno Leitao <leitao@...ian.org>
Cc: aleksander.lobakin@...el.com, kuba@...nel.org, davem@...emloft.net,
	pabeni@...hat.com, edumazet@...gle.com, elder@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, nbd@....name,
	sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
	lorenzo@...nel.org, taras.chornyi@...ision.eu,
	ath11k@...ts.infradead.org, ath10k@...ts.infradead.org,
	linux-wireless@...r.kernel.org, geomatsi@...il.com,
	kvalo@...nel.org, quic_jjohnson@...cinc.com, leon@...nel.org,
	dennis.dalessandro@...nelisnetworks.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	bpf@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
	Simon Horman <horms@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH net-next v5 02/10] net: free_netdev: exit earlier if dummy

On Wed, Apr 10, 2024 at 06:13:43AM -0700, Breno Leitao wrote:
> For dummy devices, exit earlier at free_netdev() instead of executing
> the whole function. This is necessary, because dummy devices are
> special, and shouldn't have the second part of the function executed.
> 
> Otherwise reg_state, which is NETREG_DUMMY, will be overwritten and
> there will be no way to identify that this is a dummy device. Also, this
> device do not need the final put_device(), since dummy devices are not
> registered (through register_netdevice()), where the device reference is
> increased (at netdev_register_kobject()/device_add()).
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>